Skip to content

Conversation

@kakserpom
Copy link
Contributor

@kakserpom kakserpom commented Dec 18, 2025

Fixes #538
Fixes #186
Fixes #305

@ptondereau
Copy link
Member

bugfix doesn't exist in conventional commit.

@coveralls
Copy link

coveralls commented Dec 18, 2025

Pull Request Test Coverage Report for Build 20425399746

Details

  • 30 of 149 (20.13%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 35.47%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/describe/mod.rs 2 4 50.0%
src/describe/stub.rs 0 6 0.0%
src/constant.rs 0 9 0.0%
src/convert.rs 7 37 18.92%
crates/macros/src/function.rs 11 83 13.25%
Files with Coverage Reduction New Missed Lines %
src/constant.rs 3 0.0%
Totals Coverage Status
Change from base Build 20416026788: -0.6%
Covered Lines: 1693
Relevant Lines: 4773

💛 - Coveralls

@kakserpom kakserpom changed the title bugfix(macro): nullable parameters #538 fix(macro): nullable parameters #538 Dec 18, 2025
@kakserpom
Copy link
Contributor Author

@ptondereau What a weird CI fail...

ptondereau
ptondereau previously approved these changes Dec 21, 2025
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kakserpom kakserpom force-pushed the 538_nullable_param branch 2 times, most recently from fdb4a91 to e0af8c1 Compare December 21, 2025 17:18
ptondereau
ptondereau previously approved these changes Dec 21, 2025
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@ptondereau ptondereau merged commit 6523879 into extphprs:master Dec 22, 2025
64 checks passed
@kakserpom kakserpom deleted the 538_nullable_param branch December 22, 2025 13:46
@Xenira Xenira mentioned this pull request Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants